Update to use final 0.3.0 contracts #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alpe
approved these changes
Jun 28, 2023
| @@ -113,8 +113,22 @@ func TestMVP(t *testing.T) { | |||
|
|
|||
| assert.Equal(t, 70_000_000, providerCli.QueryVaultFreeBalance()) | |||
|
|
|||
| // Cross Stake - A user pulls out additional liens on the same collateral "cross staking" it on different chains. | |||
| // @alpe these lines pass, but when I run them, the following providerCli.MustExecVault(execMsg) fails with | |||
There was a problem hiding this comment.
Good call. I will add fix to wasmd and make this work here.
There was a problem hiding this comment.
I would be happy for merge and release of this (so we have 0.3.0 mesh-security-sdk that can be tested).
And then the wasmd stuff afterwards in a patch release. Test works and shows it is enforced, but it breaks others. This is more about maintainability than correctness of current code, so can add to a patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #45 to final release.
Please merge into that PR and update that PR's title.
One item is untestable due to an issue in ibctesting. I mean, I could test it, but it breaks all tests afterwards.
I would merge as is, and work on the fix in a wasmd release in parallel, and then uncomment in the future when ibctesting update is out.