Upgrade contracts to v0.3.0 with better tests #45
+434
−180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alpe
commented
Jun 27, 2023
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -116,6 +127,6 @@ | |||
|
|
|||
| // EndBlock executed after every block. It returns no validator updates. | |||
| func (am AppModule) EndBlock(ctx sdk.Context, _ abci.RequestEndBlock) []abci.ValidatorUpdate { | |||
| EndBlocker(ctx, am.k) | |||
| EndBlocker(ctx, am.k, am.asyncTaskRspHandler) | |||
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods
|
Are you really using alpha.1 contracts, not beta.2? It would be good to update the PR name. It would also be good to have a download script there that also writes |
Update to use final 0.3.0 contracts
alpe
changed the title
ethanfrey
reviewed
Jun 28, 2023
| resp, err := p.chain.SendMsgs(&wasmtypes.MsgExecuteContract{ | ||
| Sender: p.chain.SenderAccount.GetAddress().String(), | ||
| Contract: contract.String(), | ||
| Msg: []byte(payload), | ||
| Funds: funds, | ||
| }) | ||
| require.Error(p.t, err, "Response: %v", resp) | ||
| // workaround sequence issue until wasmd testchain code is updated | ||
| p.chain.NextBlock() | ||
| require.NoError(p.t, p.chain.SenderAccount.SetSequence(p.chain.SenderAccount.GetSequence()+1)) |
pinosu
reviewed
Jun 28, 2023
| assert.Equal(t, 50_000_000, providerCli.QueryVaultFreeBalance()) | ||
|
|
||
| // provider chain | ||
| // ============== |
pinosu
reviewed
Jun 28, 2023
| externalStaking sdk.AccAddress | ||
| } | ||
|
|
||
| func (p *TestProviderClient) BootstrapContracts(connId, portID string) ProviderContracts { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade contracts to v0.3.0
Full IBC enabled end to end test of stake, unstake