-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove genesis supply offsets #305
Conversation
We should change NewGenesisState as done here, and make a new method for |
Updated according to @ValarDragon's comments. Less changes this way (even if we keep the legacy GenesisSuplyOffsets around) |
@alexanderbez I tried merging main into this branch, but had issues with the integrations on the osmosis side. Are the changes from a296bdc already reflected on osmosis/main? |
Closing in favor of #312 |
Needed for osmosis-labs/osmosis#2307
What is the purpose of the change
The sdk fork is using GenesisSupplyOffsets in the banktypes.NewGenesisState() constructor. This is incompatible with the ibc-go testing package which expects the new signature (https://github.com/cosmos/ibc-go/tree/main/testing).
Brief Changelog
Testing and Verifying
Tests pass
Documentation and Release Note
Unreleased
section inCHANGELOG.md
? (no)