You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The sdk fork is using GenesisSupplyOffsets in the banktypes.NewGenesisState() constructor. This is incompatible with the ibc-go testing package which expects the new signature (https://github.com/cosmos/ibc-go/tree/main/testing).
Suggested Design
Remove outdated GenesisSupplyOffsets from the sdk fork and make the necessary changes to both this repo and the sdk fork for the tests to pass
Add a new constructor to x/bank's GenesisState that uses offsets and remove the legacy parameter from the default constructor
Acceptance Criteria
Tests pass on both repos
Someone that understands the genesis state has reviewed the changes (on both repos) to make sure they're ok
The text was updated successfully, but these errors were encountered:
nicolaslara
changed the title
Remove outdated GenesisSupplyOffsets from the sdk fork
Remove outdated GenesisSupplyOffsets from the sdk fork's bank genesis state constructor
Aug 5, 2022
nicolaslara
changed the title
Remove outdated GenesisSupplyOffsets from the sdk fork's bank genesis state constructor
Updated outdated GenesisSupplyOffsets to match the sdk fork's bank genesis state constructor
Aug 15, 2022
Background
The sdk fork is using
GenesisSupplyOffsets
in thebanktypes.NewGenesisState()
constructor. This is incompatible with the ibc-go testing package which expects the new signature (https://github.com/cosmos/ibc-go/tree/main/testing).Suggested Design
Remove outdated GenesisSupplyOffsets from the sdk fork and make the necessary changes to both this repo and the sdk fork for the tests to passAdd a new constructor to x/bank's
GenesisState
that uses offsets and remove the legacy parameter from the default constructorAcceptance Criteria
The text was updated successfully, but these errors were encountered: