Remove unused floating-point based node storage code #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only way to use this code used to be to edit the source and modify defines, so it has recieved no testing over the last few years and is dead code.
|
The fixed-point based storage is using a projection dependent scale which is only set correctly for WGS84 and Mercator. Using floating point storage might be the only option to use other projections at the moment. See also #121. |
We need to get some test coverage of other projections, I don't think we have any right now. |
|
There are compile errors on Windows without -DFIXED_CODE, by the way (Appveyor will detect them if we add an option in cmake script) |
|
Closed in #668 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only way to use this code used to be to edit the source and modify defines, so it has received no testing over the last few years and is dead code.