Remove unneeded parent call method for FPGroup
#4347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasBreuer
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Yes, the load method in question does not use this function.
The failures come from another place where this function is used.
I am currently anyhow changing the code in question, and will make a pull request for that soon. Perhaps the easiest solution is to wait for that to happen, and to rebase.
fingolfin
approved these changes
Nov 28, 2024
|
With the changes of @ThomasBreuer in #4357, CI now seems to be happy about this. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4347 +/- ##
==========================================
+ Coverage 84.36% 84.47% +0.11%
==========================================
Files 656 656
Lines 87196 87650 +454
==========================================
+ Hits 73559 74044 +485
+ Misses 13637 13606 -31
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4202 (comment) for the motivation to remove it.
This method is not documented, nor is it used for group serialization atm (at least not needed for the tests to succeed).