Skip to content

Commit

Permalink
Remove unneeded parent call method for FPGroup (#4347)
Browse files Browse the repository at this point in the history
  • Loading branch information
lgoettgens authored Dec 5, 2024
1 parent 3b56941 commit 7e93d11
Showing 1 changed file with 0 additions and 17 deletions.
17 changes: 0 additions & 17 deletions src/Groups/GAPGroups.jl
Original file line number Diff line number Diff line change
Expand Up @@ -2366,23 +2366,6 @@ function (G::FPGroup)(pairs::AbstractVector{Pair{T, S}}) where {T <: IntegerUnio
return FPGroupElem(G, w)
end

# This format is used in the serialization of `FPGroupElem`.
function (G::FPGroup)(extrep::AbstractVector{T}) where T <: IntegerUnion
famG = GAPWrap.ElementsFamily(GAPWrap.FamilyObj(GapObj(G)))
if GAP.Globals.IsFreeGroup(GapObj(G))
w = GAPWrap.ObjByExtRep(famG, GapObj(extrep, true))
else
# For quotients of free groups, `GAPWrap.ObjByExtRep` is not defined.
F = GAP.getbangproperty(famG, :freeGroup)
famF = GAPWrap.ElementsFamily(GAPWrap.FamilyObj(F))
w1 = GAPWrap.ObjByExtRep(famF, GapObj(extrep, true))
w = GAPWrap.ElementOfFpGroup(famG, w1)
end

return FPGroupElem(G, w)
end


function describe(G::FinGenAbGroup)
l = elementary_divisors(G)
length(l) == 0 && return "0" # trivial group
Expand Down

0 comments on commit 7e93d11

Please sign in to comment.