Fix differences between 8.4 and 8.5 image definitions #1594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achilleas-k
force-pushed
the
fix/84-85-diffs
branch
from
700d1e1 to
e7b77ae
Compare
The package set is needed by the GRUB 2 stage options function to find the Kernel package in order to add the saved entry option. The Kernel package is defined in the blueprints package set, not the OS package set. Signed-off-by: Achilleas Koutsou <[email protected]>
Signed-off-by: Achilleas Koutsou <[email protected]>
Signed-off-by: Achilleas Koutsou <[email protected]>
achilleas-k
force-pushed
the
fix/84-85-diffs
branch
from
e7b77ae to
1acc0bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes:
This PR is the result of a short investigation into the differences between the image types in RHEL 8.4 and 8.5, based on the output of the
image-infotool (as it currently exists in the test manifests).Elements fixed in this PR:
We (well, mostly @thozza) are working towards updating the AMI definitions to match the official images (https://issues.redhat.com/browse/COMPOSER-837). The AMI definition I added in RHEL 8.5: main image types #1536 was an initial step towards this, where I updated the package list from the 8.4 definition. Unfortunately, I neglected to include some packages to the exclusion list. That's been fixed now.As a consequence of the new way the blueprint packages are handled (as a separate package set), the wrong package set was searched for to detect the kernel and add the saved GRUB 2 value. Fixed now.
Below is a list of other differences and the reasons they appeared.
All (or most) image types
New udev rule
Introduced in 8.5
Added by
rdma-core.New package dependency for
libpcap.New rhsm options
auto_registrationauto_registration_intervalAdded in org.osbuild.rhsm stage
Edge commit
rhsm.conf
Removed from 8.5.
This is expected: Subscription manager was meant to be excluded (#893) but then was re-added (un-excluded) (#1231) to edge image types. Now it's no longer installed even when not explicitly excluded.
dnf
Removed from 8.5
This is expected: dependency of subman (see above).