-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal/distro/rhel8: un-exclude subman from edge #1231
Conversation
is there any way I can grab an artifact rpm to test it on a live rhel box? |
If you check the schitzbot logs you'll find a repo with the rpm built from your pr. |
thanks Tom! I'm afraid the bot just failed w/o producing any artifact (unless I'm completely blind) |
I think we broke Schutzbot by the last merged PR. #1232 should fix it. When it's merged, this PR needs a rebase. |
OK, #1232 is merged, please rebase your PR on top of main. |
e4caca7
to
80593e8
Compare
alrighty, this should be good to go now /cc @nullr0ute |
337ccb4
to
dedeac1
Compare
Yep, LGTM, we can revisit this in the 8.5 cycle as part of engaging with the rhc team. |
May I ask for a rebase? Schuzbot is somehow confused and I have no clue why. |
8563d0c
to
01292d5
Compare
rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙆
I think that this change pulled in The test specifically checks that See:
|
I need to drop that then as we're aware dnf is going to be pulled in for now |
We aim at shrinking our deps eventually but we need subman for the time being. This patch basically un-exclude subman which was introduced by osbuild#893 Signed-off-by: Antonio Murdaca <[email protected]>
@ondrejbudai I've skipped that test on rhel 8.4 but running elsewhere - we'll revisit that going forward - now there are other jobs failing but they look unrelated afaict. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
We aim at shrinking our deps eventually but we need subman for the time
being. This patch basically un-exclude subman which was introduced by
#893
Signed-off-by: Antonio Murdaca [email protected]