Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/distro/rhel8: un-exclude subman from edge #1231

Merged
merged 1 commit into from
Feb 18, 2021

Conversation

runcom
Copy link
Member

@runcom runcom commented Feb 16, 2021

We aim at shrinking our deps eventually but we need subman for the time
being. This patch basically un-exclude subman which was introduced by
#893

Signed-off-by: Antonio Murdaca [email protected]

@runcom
Copy link
Member Author

runcom commented Feb 16, 2021

is there any way I can grab an artifact rpm to test it on a live rhel box?

@teg
Copy link
Member

teg commented Feb 16, 2021

If you check the schitzbot logs you'll find a repo with the rpm built from your pr.

@runcom
Copy link
Member Author

runcom commented Feb 16, 2021

If you check the schitzbot logs you'll find a repo with the rpm built from your pr.

thanks Tom! I'm afraid the bot just failed w/o producing any artifact (unless I'm completely blind)

@ondrejbudai
Copy link
Member

I think we broke Schutzbot by the last merged PR. #1232 should fix it. When it's merged, this PR needs a rebase.

@ondrejbudai
Copy link
Member

OK, #1232 is merged, please rebase your PR on top of main.

@runcom runcom force-pushed the needs-subman branch 2 times, most recently from e4caca7 to 80593e8 Compare February 16, 2021 17:06
@runcom runcom changed the title [DO NOT MERGE] un-exclude subman from edge internal/distro/rhel8: un-exclude subman from edge Feb 16, 2021
@runcom
Copy link
Member Author

runcom commented Feb 16, 2021

alrighty, this should be good to go now /cc @nullr0ute

@runcom runcom force-pushed the needs-subman branch 2 times, most recently from 337ccb4 to dedeac1 Compare February 17, 2021 09:44
@nullr0ute
Copy link
Contributor

Yep, LGTM, we can revisit this in the 8.5 cycle as part of engaging with the rhc team.

@ondrejbudai
Copy link
Member

May I ask for a rebase? Schuzbot is somehow confused and I have no clue why.

@runcom runcom force-pushed the needs-subman branch 2 times, most recently from 8563d0c to 01292d5 Compare February 17, 2021 11:21
@runcom
Copy link
Member Author

runcom commented Feb 17, 2021

May I ask for a rebase? Schuzbot is somehow confused and I have no clue why.

rebased

gicmo
gicmo previously approved these changes Feb 17, 2021
Copy link
Contributor

@gicmo gicmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙆

@ondrejbudai
Copy link
Member

ondrejbudai commented Feb 17, 2021

I think that this change pulled in dnf (at least the failed test shows it). Is this expected?

The test specifically checks that dnf isn't in the image.

See:

- name: dnf should not be installed

@runcom
Copy link
Member Author

runcom commented Feb 17, 2021

I think that this change pulled in dnf (at least the failed test shows it). Is this expected?

I need to drop that then as we're aware dnf is going to be pulled in for now

We aim at shrinking our deps eventually but we need subman for the time
being. This patch basically un-exclude subman which was introduced by
osbuild#893

Signed-off-by: Antonio Murdaca <[email protected]>
@runcom
Copy link
Member Author

runcom commented Feb 18, 2021

@ondrejbudai I've skipped that test on rhel 8.4 but running elsewhere - we'll revisit that going forward - now there are other jobs failing but they look unrelated afaict.

@ondrejbudai
Copy link
Member

Affected by #1202 and #1237, otherwise green.

Copy link
Member

@ondrejbudai ondrejbudai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ondrejbudai ondrejbudai merged commit 2131952 into osbuild:main Feb 18, 2021
@runcom runcom deleted the needs-subman branch February 18, 2021 12:10
@henrywang henrywang mentioned this pull request Feb 25, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants