Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

awscloud: implement retrieval of bucket and permissions (HMS-3099) #539

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

schuellerf
Copy link
Contributor

Implements

  • function to list available AWS buckets and
  • function to check bucket permissions

This is a prerequisite for osbuild/bootc-image-builder#220

…not sure why there is no type similar to type S3Permission string defined in the upstream library...

@schuellerf schuellerf changed the title awscloud: implement retrieval of bucket and permissions HMS-3099 awscloud: implement retrieval of bucket and permissions (HMS-3099) Mar 21, 2024
@schuellerf schuellerf enabled auto-merge March 21, 2024 16:59
@ochosi ochosi requested a review from achilleas-k March 21, 2024 22:25
achilleas-k
achilleas-k previously approved these changes Mar 21, 2024
Copy link
Member

@achilleas-k achilleas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Tiny nitpick about comments or a docstring but not super important. Approving.

pkg/cloud/awscloud/awscloud.go Show resolved Hide resolved
pkg/cloud/awscloud/awscloud.go Show resolved Hide resolved
@schuellerf schuellerf force-pushed the HMS-3099-check-s3-bucket branch from 5afd814 to c9ae70a Compare March 22, 2024 09:01
@schuellerf schuellerf added this pull request to the merge queue Mar 22, 2024
Merged via the queue into osbuild:main with commit d9d136e Mar 22, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants