Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

main: check s3 bucket access before starting (HMS-3099) #298

Merged
merged 3 commits into from
Apr 3, 2024
Merged

main: check s3 bucket access before starting (HMS-3099) #298

merged 3 commits into from
Apr 3, 2024

Conversation

schuellerf
Copy link
Contributor

Check AWS S3 bucket and permission before starting the build.

Resolves #220

PR osbuild/images#539 needs to be merged & deployed before

@schuellerf schuellerf changed the title main: check s3 bucket access before starting HMS-3099 main: check s3 bucket access before starting (HMS-3099) Mar 21, 2024
@schuellerf schuellerf marked this pull request as draft March 21, 2024 11:33
@schuellerf schuellerf force-pushed the HMS-3099-check-s3-bucket branch 2 times, most recently from 0a6d066 to 84b53bd Compare March 25, 2024 09:48
@schuellerf schuellerf force-pushed the HMS-3099-check-s3-bucket branch from 84b53bd to 5b2c46f Compare April 2, 2024 13:10
mvo5
mvo5 reviewed Apr 2, 2024
View reviewed changes
Copy link
Collaborator

@mvo5 mvo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some really quick drive-by comments for your consideration. Also go fmt is needed or our linters will be unhappy (or should be if they are not already :)

bib/cmd/bootc-image-builder/main.go Outdated Show resolved Hide resolved
bib/cmd/bootc-image-builder/main.go Outdated Show resolved Hide resolved
bib/cmd/bootc-image-builder/main.go Outdated Show resolved Hide resolved
bib/cmd/bootc-image-builder/main.go Outdated Show resolved Hide resolved
@schuellerf schuellerf force-pushed the HMS-3099-check-s3-bucket branch from eefb71b to 99e6f12 Compare April 2, 2024 16:16
@schuellerf schuellerf marked this pull request as ready for review April 2, 2024 16:16
@schuellerf schuellerf requested a review from mvo5 April 2, 2024 16:28
cgwalters
cgwalters reviewed Apr 2, 2024
View reviewed changes
Containerfile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
bib/cmd/bootc-image-builder/main.go Outdated Show resolved Hide resolved
@schuellerf schuellerf force-pushed the HMS-3099-check-s3-bucket branch from 99e6f12 to c53f919 Compare April 3, 2024 10:03
@schuellerf schuellerf force-pushed the HMS-3099-check-s3-bucket branch from c53f919 to e60c91f Compare April 3, 2024 10:04
@schuellerf schuellerf enabled auto-merge April 3, 2024 10:26
@schuellerf schuellerf added this pull request to the merge queue Apr 3, 2024
Merged via the queue into osbuild:main with commit 775a176 Apr 3, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgwalters cgwalters cgwalters left review comments

@ondrejbudai ondrejbudai ondrejbudai approved these changes

@mvo5 mvo5 Awaiting requested review from mvo5

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check that the given S3 bucket exists before building an image
4 participants
@schuellerf @ondrejbudai @cgwalters @mvo5