disk: extract maybeAddBootPartition() helper
#1062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Those two are not used outside of `disk` so let's unexport them to keep a smaller API. Followups, c.f. osbuild#1041 (comment)
This commit extracts a new `maybeAddBootPartition()` helper to make the `NewCustomPartitionTable()` a little bit more linear to read. Followup, c.f. osbuild#1041 (comment)
mvo5
force-pushed
the
disk-unexport-things
branch
from
3d6d710 to
bf0b53d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit extracts a new
maybeAddBootPartition()helper tomake the
NewCustomPartitionTable()a little bit more linearto read.
Followup, c.f.
#1041 (comment)
disk: unexport
AddBootPartitionandAddPartitionsForBootModeThose two are not used outside of
diskso let's unexport themto keep a smaller API.
Followups, c.f.
#1041 (comment)