Skip to content

Commit

Permalink
disk: extract maybeAddBootPartition() helper
Browse files Browse the repository at this point in the history
This commit extracts a new `maybeAddBootPartition()` helper to
make the `NewCustomPartitionTable()` a little bit more linear
to read.

Followup, c.f.
#1041 (comment)
  • Loading branch information
mvo5 authored and achilleas-k committed Nov 25, 2024
1 parent 56fbd91 commit 70443b4
Showing 1 changed file with 29 additions and 19 deletions.
48 changes: 29 additions & 19 deletions pkg/disk/partition_table.go
Original file line number Diff line number Diff line change
Expand Up @@ -1155,6 +1155,28 @@ func (options *CustomPartitionTableOptions) getfstype(fstype string) (string, er
return options.DefaultFSType.String(), nil
}

func maybeAddBootPartition(pt *PartitionTable, disk *blueprint.DiskCustomization, defaultFSType FSType) error {
// The boot type will be the default only if it's a supported filesystem
// type for /boot (ext4 or xfs). Otherwise, we default to xfs.
// FS_NONE also falls back to xfs.
var bootFsType FSType
switch defaultFSType {
case FS_EXT4, FS_XFS:
bootFsType = defaultFSType
default:
bootFsType = FS_XFS
}

if needsBoot(disk) {
// we need a /boot partition to boot LVM or Btrfs, create boot
// partition if it does not already exist
if err := addBootPartition(pt, bootFsType); err != nil {
return err
}
}
return nil
}

// NewCustomPartitionTable creates a partition table based almost entirely on the disk customizations from a blueprint.
func NewCustomPartitionTable(customizations *blueprint.DiskCustomization, options *CustomPartitionTableOptions, rng *rand.Rand) (*PartitionTable, error) {
if options == nil {
Expand Down Expand Up @@ -1184,30 +1206,18 @@ func NewCustomPartitionTable(customizations *blueprint.DiskCustomization, option
return nil, fmt.Errorf("%s invalid partition table type enum value: %d", errPrefix, options.PartitionTableType)
}

// add any partition(s) that are needed for booting (like /boot/efi)
// if needed
//
// TODO: switch to ensure ESP in case customizations already include it
if err := addPartitionsForBootMode(pt, options.BootMode); err != nil {
return nil, fmt.Errorf("%s %w", errPrefix, err)
}

// The boot type will be the default only if it's a supported filesystem
// type for /boot (ext4 or xfs). Otherwise, we default to xfs.
// FS_NONE also falls back to xfs.
var bootFsType FSType
switch options.DefaultFSType {
case FS_EXT4, FS_XFS:
bootFsType = options.DefaultFSType
default:
bootFsType = FS_XFS
}

if needsBoot(customizations) {
// we need a /boot partition to boot LVM or Btrfs, create boot
// partition if it does not already exist
if err := addBootPartition(pt, bootFsType); err != nil {
return nil, fmt.Errorf("%s %w", errPrefix, err)
}
// add the /boot partition (if it is needed)
if err := maybeAddBootPartition(pt, customizations, options.DefaultFSType); err != nil {
return nil, fmt.Errorf("%s %w", errPrefix, err)
}

// add user customized partitions
for _, part := range customizations.Partitions {
switch part.Type {
case "plain", "":
Expand Down

0 comments on commit 70443b4

Please sign in to comment.