-
-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow injection of Pod repository annotations #68
Conversation
Updated Version Generated a new Helm chart
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove all docs/
changes as those will be generated by the CI
docs/helm/charts/index.yaml
Outdated
@@ -3,7 +3,7 @@ entries: | |||
example-idp: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is autogenerated when we release a new version via git. Please revert this :)
Co-Authored-By: hackerman <[email protected]>
Co-Authored-By: hackerman <[email protected]>
3dff61c
to
d3971ff
Compare
d3971ff
to
f77a306
Compare
Co-Authored-By: hackerman <[email protected]>
Thank you! |
Related issue
Github issue: #278
Proposed changes
In order to be able to inject Pod resource annotation, I need to update the
Deployment
template. This is, in my case, needed in order to make the readiness/liveness probes work properly with istio enabled (istio.io/docs/ops/app-health-check/#use-annotations-on-pod).Checklist
vulnerability, I confirm that I got green light (please contact [email protected]) from the maintainers to push the changes.
Further comments
I have generated a new version of Oathkeeper helm chart (
helm package --app-version 0.0.29 --version 0.0.29 ./oathkeeper
), moved the archive indocs/helm/charts
and regenerated theindex.yaml
(helm repo index .
). Please don't hesitate to let me know if I miss something or if not the way we do that (I have 10 days experience with Helm ;-))