Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Helm chart] Quick changes #278

Closed
ggimes opened this issue Oct 18, 2019 · 2 comments
Closed

[Helm chart] Quick changes #278

ggimes opened this issue Oct 18, 2019 · 2 comments

Comments

@ggimes
Copy link

ggimes commented Oct 18, 2019

Is your feature request related to a problem? Please describe.

I noticed that having istio-injection enabled was preventing Kubelet liveness/readiness probes to reach oathkeeper API port.

Describe the solution you'd like

In order to solve it, I need to either remove the api port from the Pod definition or add an annotation in the Pod resource (https://istio.io/docs/ops/app-health-check/#use-annotations-on-pod). For this second and better option, the Deployment template needs to be updated (see below). There are some other minor changes as well.

  • helm/oathkeeper/Chart.yaml (Update: Line 22)
<<< version: 0.0.24
>>> version: 0.0.28
  • helm/oathkeeper/templates/deployment.yaml (Add: Line 11)
  labels:
{{ include "oathkeeper.labels" . | indent 4 }}
# Add the posssibility to add Annnotations to the Pod resource. 
# Needed for Istio for instance:
# https://istio.io/docs/ops/app-health-check/#use-annotations-on-pod
>>>  {{- with .Values.deployment.annotations }}
>>>  annotations:
>>>    {{- toYaml . | nindent 4 }}
>>>  {{- end }}

I also noticed that the demo mode doesn't work anymore because the access-rules definitions from https://raw.githubusercontent.com/ory/k8s/master/helm/charts/oathkeeper/demo/access-rules.json is outdated (mutator -> mutators)

Thanks

@aeneasr
Copy link
Member

aeneasr commented Oct 19, 2019

Feel free to shoot up a PR :)

@aeneasr
Copy link
Member

aeneasr commented Oct 26, 2019

Merged :)

@aeneasr aeneasr closed this as completed Oct 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants