Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OField message slot not rendered when horizontal #427

Closed
lucifilote opened this issue Oct 12, 2022 · 6 comments · Fixed by #433 or #906
Closed

OField message slot not rendered when horizontal #427

lucifilote opened this issue Oct 12, 2022 · 6 comments · Fixed by #433 or #906
Assignees
@yoji-kojio
Labels
bug Something isn't working

Comments

@lucifilote
Copy link

Overview of the problem

Oruga version: [0.5.6]
Vuejs version: [2.7.10]
OS/Browser:

Description

When using
<o-field horizontal>
<template #message>Message goes here</template>
</o-field>

The #message slot is not rendered.

Steps to reproduce

  1. Create an o-field with horizontal set to true
  2. add child template for slot #message

Expected behavior

Message slot should be rendered

Actual behavior

Message slot is not rendered
@yoji-kojio
Copy link
Contributor

yoji-kojio commented Oct 22, 2022 •
edited
Loading

hey @lucifilote ! I believe that this behaviour is intentional
https://github.com/oruga-ui/oruga/blob/develop/packages/oruga/src/components/field/Field.vue#L34-L40

message slot will exist only if horizontal props is not enabled!

@yoji-kojio
Copy link
Contributor

@jtommy @astagi can you tell us if this is intentional or a bug? 😸

@jtommy
Copy link
Member

jtommy commented Oct 25, 2022

@yoji-kojio it's a bug!

@jtommy jtommy added the bug Something isn't working label Oct 25, 2022
@yoji-kojio
Copy link
Contributor

@jtommy can you assign to me? I will open a PR :D

@yoji-kojio yoji-kojio mentioned this issue Oct 25, 2022
Merged
jtommy pushed a commit that referenced this issue Oct 31, 2022
@yoji-kojio
fix(field): #427 show message when horizontal
9e5b406
@mat813 mat813 mentioned this issue Nov 9, 2022
Closed
jtommy added a commit that referenced this issue Nov 14, 2022
@jtommy
Revert "fix(field): #427 show message when horizontal "
8bcd9cb 
This reverts commit 9e5b406.
@jtommy
Copy link
Member

jtommy commented Nov 14, 2022

@yoji-kojio I had to revert your PR, it shows two messages and it break the HTML template

@jtommy jtommy reopened this Nov 14, 2022
@blv-rodrigoerades blv-rodrigoerades mentioned this issue Feb 14, 2023
Open
@tector
Copy link

tector commented Mar 13, 2024

Any update on this issue?

@mlmoravek mlmoravek mentioned this issue Apr 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yoji-kojio yoji-kojio

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
4 participants
@tector @jtommy @lucifilote @yoji-kojio