Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

horizontal field somewhat broken in 0.5.8 #442

Closed
mat813 opened this issue Nov 9, 2022 · 2 comments
Closed

horizontal field somewhat broken in 0.5.8 #442

mat813 opened this issue Nov 9, 2022 · 2 comments

Comments

@mat813
Copy link

mat813 commented Nov 9, 2022

Overview of the problem

Oruga version: 0.5.8
Vuejs version: 3.2.41
OS/Browser: Firefox Linux

Description

After 9e5b406 which fixes #427, it seems <o-field horizontal> is broken, there is a new div without any styling on the input side, and it lacks the correct flex attributes to display correctly.

Steps to reproduce

    <o-field horizontal label="Foo">
      <o-input></o-input>
    </o-field>

now generates

<div class="field is-horizontal">
  <div class="field-label"><label class="label">Foo</label></div>
  <div class="">
    <div class="field-body">
      <div class="field"><div class=""><!--v-if--></div><div class=""><div class="control"><input class="input" type="text" autocomplete="off"><!--v-if--><!--v-if--><!--v-if--></div><!--v-if--></div></div>
    </div><!--v-if-->
  </div>
</div>

Expected behavior

If I manually edit the html in the devtools and remove the outer div with the empty class I get what I was expecting:

20221109-114638_1425x86

Actual behavior

But with what is now generated, the right part of the field does not has the grow bits, and it gets shrunk:

20221109-114333_1442x101

@mat813
Copy link
Author

mat813 commented Nov 9, 2022

But maybe the problem is in https://github.com/oruga-ui/theme-bulma/

@jtommy
Copy link
Member

jtommy commented Nov 14, 2022

@mat813 you are right, i'll will revert it

@jtommy jtommy closed this as completed Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants