[DSL] Don’t dispatch blocks if view controller has been deallocated.

.gitignore

@@ -3,6 +3,7 @@
 
 #XCode stuff
 build/*
+DerivedData
 *.pbxuser
 !default.pbxuser
 *.mode1v3

.travis.yml

@@ -1,15 +1,13 @@
 language: objective-c
-osx_image: xcode7.1
+osx_image: xcode9
 env:
   global:
     - LC_CTYPE=en_US.UTF-8
     - LANG=en_US.UTF-8
 before_script:
   - echo -e "Host *\n\tStrictHostKeyChecking no\n" >> ~/.ssh/config
-  - gem install cocoapods --no-document --pre --quiet
   - bundle exec danger
-  - cd Example; pod update ; cd ..
-
-xcode_workspace: Example/ARAnalyticsTests.xcworkspace
-xcode_scheme: ARAnalyticsBootstrapiOS
-xcode_sdk: iphonesimulator
+  - cd Example; pod install; cd ..
+
+script:
+  - set -o pipefail && xcodebuild -workspace Example/ARAnalyticsTests.xcworkspace -scheme ARAnalyticsBootstrapiOS -configuration Debug test -sdk iphonesimulator -destination platform='iOS Simulator',OS='9.0',name='iPhone 6' CODE_SIGNING_REQUIRED=NO | bundle exec xcpretty

ARDSL.m

@@ -150,6 +150,9 @@ + (void)addScreenMonitoringAnalyticsHook:(NSDictionary *)screenDictionary {
             __weak __typeof(instance) weakInstance = instance;
             [[instance rac_signalForSelector:selector] subscribeNext:^(RACTuple *parameters) {
                 id instance = weakInstance;
+                if (instance == nil) {
+                    return;
+                }
 
                 BOOL shouldFire = ar_shouldFireForInstance(object, instance, parameters);
 

CHANGELOG.md

@@ -4,6 +4,7 @@
 
 * Allows AdjustProvider to be set up with an AdjustDelegate
 * Support custom event tracking for HockeyApp provider (@wzs)
+* Don’t dispatch DSL blocks if view controller has been deallocated in the mean time (@alloy)
 
 ## Version 4.0.1
 

Dangerfile

@@ -1,13 +1,13 @@
 # Sometimes it's a README fix, or something like that - which isn't relevant for
 # including in a project's CHANGELOG for example
-declared_trivial = (pr_title + pr_body).include?("#trivial")
+declared_trivial = (github.pr_title + github.pr_body).include?("#trivial")
 
 # Make it more obvious that a PR is a work in progress and shouldn't be merged yet
-warn("PR is classed as Work in Progress") if pr_title.include? "[WIP]"
+warn("PR is classed as Work in Progress") if github.pr_title.include? "[WIP]"
 
 # Warn when there is a big PR
-warn("Big PR") if lines_of_code > 500
+warn("Big PR") if git.lines_of_code > 500
 
-if !modified_files.include?("CHANGELOG.md") && !declared_trivial
+if !git.modified_files.include?("CHANGELOG.md") && !declared_trivial
   fail("Please include a CHANGELOG entry. \nYou can find it at [CHANGELOG.md](https://github.com/orta/ARAnalytics/blob/master/CHANGELOG.md).")
-end
+end