[DSL] Don’t dispatch blocks if view controller has been deallocated. #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alloy
force-pushed
the
weak-vc-fix
branch
3 times, most recently
from
a29e576 to
5bc2dd1
Compare
|
I don’t know why this is failing. Works fine locally and I’ve changed the Xcode project to build with deployment target 9.0 |
|
Will take a look |
|
Boo - hiss, works fine on my machine too. |
|
I bet it's the |
|
OK, cool 👍 |
|
@alloy this is now shipped as 4.0.2 |
|
Ahhhhhhhhhh, yeah makes total sense. Thanks 🙌 |
alloy
added a commit
to artsy/eigen
that referenced
this pull request
Jul 21, 2017
Instead we’ll see if updating ARAnalytics fixes these, see: orta/ARAnalytics#301
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I haven’t been able to proof it, nor create a failing test, I’m pretty sure that this issue leads to some of the cases we’re having where blocks that try to grab properties from VCs that really should not be
nillead to exceptions because we’re trying to insertnilinto aNSDictionary.Also did some faffing to get test suite to run on iOS 9 and some cleanup (not sure why there was a copy of the podspec in
Example/?).