added check H5_USE_1xx_API to make sure H5 is not using older API.

[guj]

No description provided.

[chuckatkins]

Can you rebase this on release_28 re-target it for that branch so it can easily go into a patch release?

[chuckatkins]

Fixes #3149

[chuckatkins]

@eschnett does this fix #3149 for you?

[eschnett]

HDF5 offers a simpler way to achieve this. I recommend calling H5Oget_info1 instead, which always accepts 2 arguments. Alternatively, H5Oget_info2 always accepts 3 arguments. These functions should exist starting from HDF5 1.10.5.

#if H5_VERSION_GE(1, 10, 5)
    herr_t ret = H5Oget_info1(m_FileId, &oinfo);
#else
    herr_t ret = H5Oget_info(m_FileId, &oinfo);
#endif

[guj]

HDF5 offers a simpler way to achieve this. I recommend calling H5Oget_info1 instead, which always accepts 2 arguments. Alternatively, H5Oget_info2 always accepts 3 arguments. These functions should exist starting from HDF5 1.10.5.

#if H5_VERSION_GE(1, 10, 5)
    herr_t ret = H5Oget_info1(m_FileId, &oinfo);
#else
    herr_t ret = H5Oget_info(m_FileId, &oinfo);
#endif

Yes, I am aware of that. I just happen to prefer using the name get_info instead of get_info.

[eschnett]

The condition defined H5_USE_16_API && defined H5_USE_18_API looks wrong. I think the individual API selection switches are exclusive.

Do you have CI infrastructure set up to test with both older and newer HDF5 versions?

[guj]

The condition defined H5_USE_16_API && defined H5_USE_18_API looks wrong. I think the individual API selection switches are exclusive.

Do you have CI infrastructure set up to test with both older and newer HDF5 versions?

You are right. It should be ||.

Updated and checked with 1.13 with DEFAULT_API_VERSION=v18

[chuckatkins]

Rebased

I took care of the rebase