Cannot build ADIOS2 with HDF5

[eschnett]

I am building ADIOS2 2.8.0 with HDF5 1.12.1. I am building via Spack as adios2 ~fortran +hdf5 ~python. This fails with the error

  >> 1203    "/tmp/eschnetter/spack-stage/spack-stage-adios2-2.8.0-gnonxlrnqyn6uxtxbidqfh73slcwdrgs/spack-src/source/adios2/toolkit
             /interop/hdf5/HDF5Common.cpp", line 1632: error: too many arguments in function call
     1204          herr_t ret = H5Oget_info(m_FileId, &oinfo, H5O_INFO_ALL);

I assume that the problem is that ADIOS2 is expecting a different HDF5 API.

[ax3l]

ping @guj @pnorbert @chuckatkins

https://github.com/ornladios/ADIOS2/blob/v2.8.0/source/adios2/toolkit/interop/hdf5/HDF5Common.cpp#L1632

[ax3l]

This is fixed in master:

ADIOS2/source/adios2/toolkit/interop/hdf5/HDF5Common.cpp

Lines 1631 to 1639 in 00a7dca

	#if H5_VERSION_GE(1, 11, 0)
	#if (defined H5_USE_16_API || defined H5_USE_18_API)
	herr_t ret = H5Oget_info(m_FileId, &oinfo);
	#else
	herr_t ret = H5Oget_info(m_FileId, &oinfo, H5O_INFO_ALL);
	#endif
	#else
	herr_t ret = H5Oget_info(m_FileId, &oinfo);
	#endif

aka 55433ec / #3156

It's already marked for the 2.8.1 release (also part of release_28 branch).

[pnorbert]

this is fixed by PR #3156 and will be in 2.8.1 patch release

[vicentebolea]

Should this be closed?