Fix JSX highlight in parens after a keyword. #148 #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The match proposed in orktes@c267e8e somehow prevents the lines inside a pair of following parentheses from being parsed as JSX; the parser falls back to plain JS where angle brackets are highlighted as operators. This causes orktes#148 The match in this fix embraces the whole expression and instructs to parse its contents with nested patterns which include JSX.
Fix tests to pass on types of numeric constants.
|
Hi! I made a more generic fix to the latest version to resolve the issue. Closing this one. Thanks for the effort. |
|
The more generic fix is in this commit, in case someone is interested, like me. @orktes thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The match proposed in c267e8e somehow prevents the lines inside a pair of following parentheses from being parsed as JSX; the parser falls back to plain JS where angle brackets are highlighted as operators. This causes #148
The match in this fix embraces the whole expression and instructs to parse its contents with nested patterns which include JSX.