Syntax highlighting issue with Atom 1.6

[armed]

Tags is not highlighted when JSX inside parentheses:

But highlights if without parentheses:

[sompylasar]

The issue appears in 0.14.1 and does not appear in 0.14.0.

[sompylasar]

This commit, besides the README change, is the only change between 0.14.0 and 0.14.1 (refs #138).

[levrik]

I can add that the auto closing is not working anymore since Atom 1.6

[sompylasar]

A duct tape fix here: #149
Either TextMate grammars are crap in terms of describing nested language constructs, or grammar developers can't grasp the concepts that enable doing it properly.

[orktes]

Hi! This should be fixed in v0.14.2.

[orktes]

Closing for now! Feel free to reopen if issues persist.

[sompylasar]

@orktes thank you for the more generic fix, which is here in case someone is interested (referencing an issue from a commit really helps).

I can't verify the fix because of a funny bug: I've accidentally installed the facebook/react library instead of this package via apm install [email protected]. And I'm still struggling to get rid of it to no avail, it got cached somewhere. For the future, you should really consider changing the published name to something like atom-react in the Atom Package Directory.

[orktes]

True! normally I try to remember do that but only noticed the existence of this issue after pushing. Nowadays it seems to be possible to rename packages in a way that request to the old package get redirected to the new one (upgrades etc.). So not a bad idea! I'll look into it.

[sompylasar]

@orktes the wrong react got cached in ~/.atom/.apm, resolved after removing that directory. (atom/apm#529)

[ilyapalkin]

@sompylasar @orktes Highlighting doesn't work for [email protected] and Atom 1.6.0:

• JSX file is considered as Plain Text

Highlighting is broken for [email protected]

• JSX file is considered as JavaScript (JSX)

It works for [email protected]

• JSX file is considered as JavaScript (JSX)

[silvenon]

@ilyapalkin Atom sometimes saves the grammar you previously set for that file (i.e. what the broken [email protected] set for you). All my new JSX files are loaded with the proper grammar in 0.14.2.

[ilyapalkin]

@silvenon in version 0.14.1 it sets JavaScript (JSX) and higlighting looks similar to #148 (comment):

When I install 0.14.2 there is no JavaScript (JSX) grammar at all.

[silvenon]

I have no idea why this would happen, have you tried reinstalling the package?

[vaclavsvejcar]

@silvenon I have the same issue with 0.14.2, reinstalling does not help. With 0.14.2, I can't even select the Javascript (JSX) mode (not available in the modes list). When I downgrade to 0.14.0 or 0.14.1, the Javascript (JSX) mode is available, though the syntax highlighting is broken exactly same as @ilyapalkin showed on screenshot.

Tested on Atom 1.6.0, OS X 10.11.3

[sompylasar]

This is probably the same issue I encountered here. Try removing ~/.atom/.apm and then do a fresh install via GUI.

[vaclavsvejcar]

@sompylasar you're right, thanks, cleaning ~/.atom/.apm/react was sufficient and solved the issue for me

[ilyapalkin]

cleaning ~/.atom/.apm/react was sufficient and solved the issue for me

+1

[enriquecaballero]

Some weird stuff is happening again.

Not sure if the import statements, along with the class definition, should look like that.

I'm on Atom 1.6.2 with the 0.15.0 react package, on OS X 10.11.4.