Add support for west-const #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 17, 2025 19:39
West-const is `const int` whereas east-const is `int const`. They mean the same thing and both can be present at the same time (`const int const` means the same). This doesn't allow west-const in local/global variables.
West-const is `const int` whereas east-const is `int const`. They mean the same thing and both can be present at the same time (`const int const` means the same). Global variables that are initialized do not seem to work for knight-native failing with `Target label 1 is not valid` when running `hex2`.
|
Added Pushed again since I forgot to update the tests. |
stikonas
reviewed
Jan 17, 2025
As requested in oriansj/M2libc#67. The standard (C17) says in 6.2.5.2: ```text An object declared as type _Bool is large enough to store the values 0 and 1 ``` It could technically be an int but all major compilers have `sizeof(bool) == 1`.
stikonas
reviewed
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
West-const is
const intwhereas east-const isint const.They mean the same thing and both can be present at the same time (
const int constmeans the same). The compiler currently only supports east-const.I updated the test cases as described in #57 (review).
I couldn't get the global
int unused = 1;to work (even withoutconst) sinceknight-nativefailed withTarget label 1 is not valid. It might just be me having an old/incompatible version of the other tools.Let me know if you would rather have separate tests. I assumed that it would be OK to use existing files since it doesn't change behavior and we only need to check that it parses correctly.