-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pop local variables based on their size #57
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, though test checksums will need updating.
Can you update them or should I do it? It is mostly:
- Build
mescc-tools
and add them toPATH
(in particular we needhex2
andM1
). make clean test
If it doesn't pass, run
make Generate-test-answers
sha256sum test/test1000/proof > test/test1000/proof.answer
make clean test
We don't push variables on the stack based on size; so popping variables on the stack will result in an unbalanced stack. So you'll have to make our pushes onto the stack match the variable size (rather than fixed to register size) if you want this behavior in M2-Planet |
c243730
to
d756c2e
Compare
I've rebased (in case there are any significant code base changes) and updated the test answers |
Thanks, I'll test this tomorrow. |
@MaxHearnden were you actually able to compile that test program at any point. Now I'm getting |
This caused a program as simple as
to fail.