-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: deprecate --verbose and print all status output by default #1545
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1545 +/- ##
==========================================
+ Coverage 83.96% 83.99% +0.03%
==========================================
Files 119 119
Lines 5306 5316 +10
==========================================
+ Hits 4455 4465 +10
Misses 604 604
Partials 247 247 ☔ View full report in Codecov by Sentry. |
LGTM but I'm not a maintainer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should take the fix into multiple steps:
- Downgrade global level
--verbose
to command-specific level - Mark the command-specific level
--verbose
as deprecated - Propose a more meaningful flag to replace the functionality of the deprecated
--verbose
flag.
Refactoring in progress, mark this as draft for now. |
85b7302
to
b40aac5
Compare
Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
b40aac5
to
e58b7b5
Compare
Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
Experimenting another way of doing this in #1553 |
What this PR does / why we need it:
--verbose
flag out ofopts.Common
--verbose
flag is used--verbose
flag in help docsUpdates on the
oras discover
command will come in a separate PR.BEFORE:
oras pull
:oras pull --verbose
:oras pull --help
AFTER:
oras pull
:oras pull --verbose
oras pull --help
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1533
Please check the following list: