minor refactor + todo

Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
oras-project · Nov 27, 2024 · b40aac5 · b40aac5
1 parent f3b6bfd
commit b40aac5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/cmd/oras/internal/option/common.go b/cmd/oras/internal/option/common.go
@@ -30,9 +30,11 @@ const NoTTYFlag = "no-tty"
 type Common struct {
 	Debug bool
 	noTTY bool
+
 	// Verbose is deprecated. Use SuppressUntitled instead.
 	// SuppressUntitled=false is equivalent to Verbose=true, while Verbose=false
 	// no longer takes effect.
+	// TODO: remove from common
 	Verbose bool
 
 	TTY *os.File

diff --git a/internal/descriptor/descriptor.go b/internal/descriptor/descriptor.go
@@ -69,10 +69,10 @@ func Plain(desc ocispec.Descriptor) ocispec.Descriptor {
 // GetName gets a descriptor name using either title or media type.
 func GetName(desc ocispec.Descriptor) string {
 	title, ok := desc.Annotations[ocispec.AnnotationTitle]
-	if !ok {
-		return desc.MediaType
+	if ok {
+		return title
 	}
-	return title
+	return desc.MediaType
 }
 
 // GenerateContentKey generates a unique key for each content descriptor using