-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: create tty copy handler #1485
Conversation
728acc4
to
a6f0c40
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1485 +/- ##
==========================================
+ Coverage 83.98% 84.07% +0.08%
==========================================
Files 119 119
Lines 5315 5325 +10
==========================================
+ Hits 4464 4477 +13
+ Misses 604 602 -2
+ Partials 247 246 -1 ☔ View full report in Codecov by Sentry. |
9676775
to
dca91a9
Compare
dca91a9
to
10b0f2b
Compare
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
Thanks for the contribution @TerryHowe! We'll review it ASAP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The overall implementation looks good. Just need to improve tty tests on validating more detailed content.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the proposed design of tracking is better than what we have for now. We can further apply it to other commands.
b7a2ecb
to
779e5d8
Compare
1f71707
to
c939b42
Compare
c939b42
to
c045669
Compare
c045669
to
4532d32
Compare
Signed-off-by: Terry Howe <[email protected]>
Signed-off-by: Terry Howe <[email protected]>
Signed-off-by: Terry Howe <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
Signed-off-by: Terry Howe <[email protected]>
Signed-off-by: Terry Howe <[email protected]>
Signed-off-by: Terry Howe <[email protected]>
4532d32
to
9c73682
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What this PR does / why we need it:
Create tty copy handler with new
StartTracking
andStopTracking
methods.Partial: #1542
Closes: #1548