Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All oras commands should use handlers to display command output #1542

Open
1 of 7 tasks
wangxiaoxuan273 opened this issue Nov 25, 2024 · 4 comments
Open
1 of 7 tasks

Comments

@wangxiaoxuan273
Copy link
Contributor

wangxiaoxuan273 commented Nov 25, 2024

Commands that need handler improvement:

@qweeah
Copy link
Contributor

qweeah commented Nov 27, 2024

Why oras manifest push is excluded?

@wangxiaoxuan273
Copy link
Contributor Author

Why oras manifest push is excluded?

I wasn't sure if that one needs refactoring. We can add it to this issue.

@qweeah
Copy link
Contributor

qweeah commented Nov 27, 2024

If I understand correctly, the goal of this issue is to make all oras commands use handlers to display command output, which means print utilities should not be directly called in command code. In this way, you can search for usages of print utilities in files within $REPO/cmd/oras/root and include all found commands there. E.g. oras manifest push and oras blob push calls PrintStatus and should be included.

@TerryHowe
Copy link
Member

#1485 might help set the tone for generalizing handlers between text and ttty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants