feat: add MountFrom and OnMounted to CopyGraphOptions #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktarplee
requested review from
sajayantony,
shizhMSFT,
SteveLasker and
Wwwsylvia
as code owners
ktarplee
changed the title
ktarplee
force-pushed
the
580-mount-copy-refactor
branch
from
2d6b4c5 to
75b9a9f
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #665 +/- ##
==========================================
+ Coverage 75.46% 75.57% +0.11%
==========================================
Files 59 59
Lines 5640 5692 +52
==========================================
+ Hits 4256 4302 +46
- Misses 1019 1023 +4
- Partials 365 367 +2 ☔ View full report in Codecov by Sentry. |
shizhMSFT
approved these changes
Jan 5, 2024
|
@ktarplee Meanwhile, could you increase the code coverage so that the check can pass? |
ktarplee
force-pushed
the
580-mount-copy-refactor
branch
from
ef5d68c to
8d3f4c1
Compare
ktarplee
force-pushed
the
580-mount-copy-refactor
branch
from
8d3f4c1 to
ecccb8b
Compare
Wwwsylvia
reviewed
Jan 9, 2024
Adds MountFrom and OnMounted to CopyGraphOptions. Allows for trying to mount from multiple repositories. Signed-off-by: Kyle M. Tarplee <[email protected]>
ktarplee
force-pushed
the
580-mount-copy-refactor
branch
from
ecccb8b to
c971de8
Compare
|
@Wwwsylvia @shizhMSFT I pushed my changes. Sorry about the delay. |
1 task
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds MountFrom and OnMounted to CopyGraphOptions.
Allows for trying to mount from multiple repositories.
Closes #580
I think this is a better approach than my other PR #632