Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mount support for oras cp #1238

Closed
1 task
ktarplee opened this issue Jan 10, 2024 · 0 comments · Fixed by #1242
Closed
1 task

Add mount support for oras cp #1238

ktarplee opened this issue Jan 10, 2024 · 0 comments · Fixed by #1242
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@ktarplee
Copy link

What is the version of your ORAS CLI

main

What would you like to be added?

When the source and destination registries are the same, the code needs to simply needs to tell oras-go via the oras.CopyOptions that we want to mount from the source repository if available.

An example of how to do this is here. You need to implement the MountFrom function and have it return the source repository (if the registry is the same as the destination). You probably also want to implement OnMount.

Why is this needed for ORAS?

There is a large performance improvement possible if mounting is supported. crane cp has always supported mounting and now that oras-go supports mounting (via PR), we should add it to oras cp.

Are you willing to submit PRs to contribute to this feature?

  • Yes, I am willing to implement it.
@ktarplee ktarplee added enhancement New feature or request triage New issues or PRs to be acknowledged by maintainers labels Jan 10, 2024
@yizha1 yizha1 removed the triage New issues or PRs to be acknowledged by maintainers label Jan 16, 2024
@yizha1 yizha1 added this to the v1.2.0 milestone Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants