Validate the hash salt during object creation #237
Conversation
| * Used by the OLCUT configuration system, and should not be called by external code. | ||
| */ | ||
| @Override | ||
| public synchronized void postConfig() throws PropertyException{ |
There was a problem hiding this comment.
These postConfigs don't access any other resources under synchronization elsewhere in the class, so we don't need to make them synchronized to avoid static analysis false positives.
There was a problem hiding this comment.
Sure, it makes sense to only apply synchronization as needed to safely modify an attribute. I think I may have misunderstood that from a previous discussion. Thanks for clarifying.
There was a problem hiding this comment.
Yeah, the false positive only arises in Trainers as those also access the RNG field under synchronization. In practice as postConfig is always only called either from the constructor, or from OLCUT before the object is published it doesn't actually need synchronization, but the static analysis tools just see a public method and so warn on it.
* Validate the hash salt during object creation * Changes to address code review feedback
Description
These changes add validations of the hash salt during object creation, either programmatically or via the Configuration System.
Motivation
These changes fix #233