You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
The various impls of Hasher (e.g. HashCodeHasher and ModHashCodeHasher) have constructors that take salt parameters that aren't validated. So you can do something like:
ModHashCodeHasher hasher = new ModHashCodeHasher(200, "42");
but you can't subsequently call
hasher.setSalt("42");
because that calls
Hasher.validateSalt("42");
which returns false.
Seems like this is inconsistent and should be remedied by having constructors that take a salt value call the validateSalt method.
System information:
Tribuo Version: 4.2.x
The text was updated successfully, but these errors were encountered:
Describe the bug
The various impls of Hasher (e.g. HashCodeHasher and ModHashCodeHasher) have constructors that take salt parameters that aren't validated. So you can do something like:
ModHashCodeHasher hasher = new ModHashCodeHasher(200, "42");
but you can't subsequently call
hasher.setSalt("42");
because that calls
Hasher.validateSalt("42");
which returns false.
Seems like this is inconsistent and should be remedied by having constructors that take a salt value call the validateSalt method.
System information:
The text was updated successfully, but these errors were encountered: