Fixes Maven dependency issues in the OCI Java SDK #388
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(I am aware that this project is a target of an opaque software generation process, so creating a PR against generated code, strictly speaking, cannot succeed, and I have no expectation that this would be "merged", since that is a meaningless concept in this repository. I do this here to hopefully illustrate the kinds of changes that need to be made internally in some source control system prior to whatever process it is that ultimately produces the source code found in this Github repository. Hopefully some developer can take the changes and the diffs in this PR and apply them appropriately to whatever internal repository ultimately produces this one.)
This PR:
<dependencyManagement>
children which is an antipattern<properties>
stanza of the rootpom.xml
foo-client
may actually really only need to be a dependency onfoo-core
Broadly speaking: the PR implements proper Maven dependency management, which seems to be what was desired throughout the project, while making it exceedingly clear exactly which external libraries are required by exactly which subprojects.
See:
Signed-off-by: Laird Nelson [email protected]