Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spurious dependencies in bmc-encryption #385

Closed
ljnelson opened this issue Apr 6, 2022 · 3 comments
Closed

Spurious dependencies in bmc-encryption #385

ljnelson opened this issue Apr 6, 2022 · 3 comments
Labels
SDK Issue pertains to the SDK itself and not specific to any service

Comments

@ljnelson
Copy link
Member

ljnelson commented Apr 6, 2022

(I know I'm filing a lot of "issues". They're all tiny. Just noticing things as I dig into the project and don't want them to get lost, that's all. Do with them what you will!)

I noticed that the following dependencies, when removed entirely from bmc-encryption, do not impact a full build (with tests) in any way:

<dependency>
    <groupId>com.fasterxml.jackson.datatype</groupId>
    <artifactId>jackson-datatype-jsr310</artifactId>
</dependency>
<dependency>
    <groupId>com.fasterxml.jackson.datatype</groupId>
    <artifactId>jackson-datatype-jdk8</artifactId>
</dependency>
@ljnelson
Copy link
Member Author

ljnelson commented Apr 6, 2022

I can also remove these as well from bmc-common with no ill effects. Perhaps they are needed at runtime, in which case perhaps they should continue to be declared in both projects but in <scope>runtime</scope>? Or perhaps they truly are not needed at all in either project.

@jodoglevy jodoglevy added the SDK Issue pertains to the SDK itself and not specific to any service label Apr 7, 2022
@VidhiBhansali
Copy link
Member

Hi @ljnelson. Thanks for suggesting the changes. I am looking into it.

@VidhiBhansali
Copy link
Member

@ljnelson We've fixed the pom.xml in version 2.39.0 of the OCI Java SDK. Closing this issue since it has been resolved from our end but please feel free to reopen if it is still an issue after upgrading to 2.39.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SDK Issue pertains to the SDK itself and not specific to any service
Projects
None yet
Development

No branches or pull requests

3 participants