Add Uniswap pool fee as functions arg #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
haythemsellami
changed the title
haythemsellami
assigned alpinechicken, alexisgauba and KMKoushik and unassigned alpinechicken, alexisgauba and KMKoushik
#369) * fix tick test issues, update slot0 tick, and add in uniswap SqrtPriceMathPartial calcs * function names fixed * fix lib linking + tests
* calc amount to mint * fix * fix * fix * fix * refactor
haythemsellami
force-pushed
the
feat/add-pool-address
branch
from
cccda53 to
a6c73c4
Compare
aleone
approved these changes
May 2, 2022
There was a problem hiding this comment.
lgtm generally, but think we should add in logic to replace the diamond storage for wPowerPerpPool and have it be a param, like the pool fee for at least non vault based actions (batchMintLp, rebalanceWithoutVault, etc). That way someone can use the ControllerHelper to LP in non 0.3% pools. Seems pretty straightforward and makes the ControllerHelper fully agnostic to pools (LPing and trading). Note that (if easier) it doesn't need to support arbitrary pools for vault based actions (flashloan mint and LP for example) as they will fail as Controller will not accept them as collateral.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Uniswap pool fee as functions arg
Description
This will allow choosing different uniswap pool from fe/user.
Fixes #294
Type of change
How Has This Been Tested
Please describe how to test to verify the changes. Provide instructions so we can reproduce.
Checklist