fix: determine desired amounts before LPing #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
haythemsellami
changed the title
haythemsellami
pushed a commit
that referenced
this pull request
Apr 28, 2022
* calc amount to mint * fix * fix * fix * fix * refactor
haythemsellami
pushed a commit
that referenced
this pull request
Apr 29, 2022
* organize wrap/unwrapping ETH * refactor * refactooor * refactor * refactor * calc exact amount to LP * Fix: (WIPish) Improvements/fixes to "fix excess amounts when LPing" PR (#369) * fix tick test issues, update slot0 tick, and add in uniswap SqrtPriceMathPartial calcs * function names fixed * fix lib linking + tests * clean * fix: determine desired amounts before LPing (#384) * calc amount to mint * fix * fix * fix * fix * refactor * clean * Fix: redeposit NFT into vault when increasing liquidity (#386) * fix: redeposit NFT into vault when increasing liquidity * approve all NFTs * lint * remove checkExcess * fix #401 * improve #401 fix * clean Co-authored-by: Andrew <[email protected]>
haythemsellami
pushed a commit
that referenced
this pull request
Apr 29, 2022
* calc amount to mint * fix * fix * fix * fix * refactor
haythemsellami
pushed a commit
that referenced
this pull request
Apr 29, 2022
* calc amount to mint * fix * fix * fix * fix * refactor
haythemsellami
pushed a commit
that referenced
this pull request
May 4, 2022
* organize wrap/unwrapping ETH * refactor * refactooor * refactor * refactor * calc exact amount to LP * Fix: (WIPish) Improvements/fixes to "fix excess amounts when LPing" PR (#369) * fix tick test issues, update slot0 tick, and add in uniswap SqrtPriceMathPartial calcs * function names fixed * fix lib linking + tests * fix: determine desired amounts before LPing (#384) * calc amount to mint * fix * fix * fix * fix * refactor * add poolFee as functions arg * fix tests * fix compiling * clean * change compared value * update circleci * change compared value * chang ewPowerPool to be dynamic * set pool address as arg * update tests Co-authored-by: Andrew <[email protected]>
haythemsellami
pushed a commit
that referenced
this pull request
May 5, 2022
* organize wrap/unwrapping ETH * refactor * refactooor * refactor * refactor * calc exact amount to LP * Fix: (WIPish) Improvements/fixes to "fix excess amounts when LPing" PR (#369) * fix tick test issues, update slot0 tick, and add in uniswap SqrtPriceMathPartial calcs * function names fixed * fix lib linking + tests * fix: determine desired amounts before LPing (#384) * calc amount to mint * fix * fix * fix * fix * refactor * fix #401 * clean * add burnExactRemoved * lint * fix compiling * lint * fix * fix * add burnExactRemoved for rebalance vault * withdraw * lint Co-authored-by: Andrew <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: determine desired amounts before LPing
Description
Fixes # (issue)
Type of change
How Has This Been Tested
Please describe how to test to verify the changes. Provide instructions so we can reproduce.
Checklist