Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: logging issue in quick-start application #402

Merged
merged 3 commits into from
Sep 24, 2020
Merged

Fix: logging issue in quick-start application #402

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
57c2dd5
Quick-start application logging issue fixed, by replacing log4j-slf4j…
mnoman09 Sep 23, 2020
3a95099
testing srcclr by removing check, will revert once checked
mnoman09 Sep 23, 2020
176e4b8
reverting type=cron check again
mnoman09 Sep 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion java-quickstart/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ dependencies {

compile group: 'com.google.code.gson', name: 'gson', version: '2.8.6'
compile group: 'org.apache.httpcomponents', name: 'httpclient', version: '4.5.12'
compile group: 'org.apache.logging.log4j', name: 'log4j-slf4j-impl', version: '2.13.3'
compile group: 'org.slf4j', name: 'slf4j-simple', version: '1.7.30'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this is a revert to the line that was there previously. That works, tested it. But I'm not sure if maybe new Apache logger might have different logging properties setup, and this line didn't need to be reverted and instead Apache logger might need a different setup. I'm not sure.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No actually previously it was compile group: 'org.slf4j', name: 'slf4j-log4j12', version: '1.7.30' which was causing vulnerability issue due to transitive property of log4j. I now replaced it with alternative library slf4j-simple.


testCompile group: 'junit', name: 'junit', version: '4.12'
}

Expand Down