Fix: logging issue in quick-start application #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-impl with slf4j-simple this will resolve the vulnerability issue aswell
Mat001
reviewed
Sep 23, 2020
| @@ -4,7 +4,8 @@ dependencies { | |||
|
|
|||
| compile group: 'com.google.code.gson', name: 'gson', version: '2.8.6' | |||
| compile group: 'org.apache.httpcomponents', name: 'httpclient', version: '4.5.12' | |||
| compile group: 'org.apache.logging.log4j', name: 'log4j-slf4j-impl', version: '2.13.3' | |||
| compile group: 'org.slf4j', name: 'slf4j-simple', version: '1.7.30' | |||
There was a problem hiding this comment.
I see this is a revert to the line that was there previously. That works, tested it. But I'm not sure if maybe new Apache logger might have different logging properties setup, and this line didn't need to be reverted and instead Apache logger might need a different setup. I'm not sure.
There was a problem hiding this comment.
No actually previously it was compile group: 'org.slf4j', name: 'slf4j-log4j12', version: '1.7.30' which was causing vulnerability issue due to transitive property of log4j. I now replaced it with alternative library slf4j-simple.
Mat001
approved these changes
Sep 23, 2020
Pull Request Test Coverage Report for Build 1555
💛 - Coveralls |
aliabbasrizvi
approved these changes
Sep 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
FSC and all unit tests should pass.