Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2815 : Add label for AdminPinActivity #2922

Merged
merged 11 commits into from
Mar 23, 2021
Merged

Fix #2815 : Add label for AdminPinActivity #2922

merged 11 commits into from
Mar 23, 2021

Conversation

starboi02
Copy link
Contributor

@starboi02 starboi02 commented Mar 15, 2021 •
edited
Loading

Explanation

Fixes #2815 : Add label for AdminPinActivity

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@anandwana001
Copy link
Contributor

@starboi02 Please follow the checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).

@starboi02 starboi02 changed the title Fixes #2815 : Add label for AdminPinActivity Fix #2815 : Add label for AdminPinActivity Mar 16, 2021
@rt4914 rt4914 self-assigned this Mar 16, 2021
@prayutsu
Copy link
Contributor

Hi @starboi02
As mentioned in the mail, you can claim for one more issue and continue working on it while the reviewers add their reviews.
Also please update the PR description as suggested by @anandwana001
Go through our Making a code change Instructions to make a good PR and it will also make the review process faster.

Thanks!

@starboi02
Copy link
Contributor Author

Hi @starboi02
As mentioned in the mail, you can claim for one more issue and continue working on it while the reviewers add their reviews.
Also please update the PR description as suggested by @anandwana001
Go through our Making a code change Instructions to make a good PR and it will also make the review process faster.

Thanks!

Ok @prayutsu I will just start working on another good first issue in the meantime.

rt4914
rt4914 suggested changes Mar 17, 2021
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@starboi02 Suggested changes.

Also, please add details in your Explanation / Description

Something like
Fixes #2815: Add label to AdminPinActivity

app/src/main/AndroidManifest.xml Outdated Show resolved Hide resolved
app/src/sharedTest/java/org/oppia/android/app/profile/AdminPinActivityTest.kt Outdated Show resolved Hide resolved
app/src/sharedTest/java/org/oppia/android/app/profile/AdminPinActivityTest.kt Outdated Show resolved Hide resolved
@rt4914 rt4914 removed their assignment Mar 17, 2021
@rt4914
Copy link
Contributor

rt4914 commented Mar 18, 2021

@starboi02 Please make sure that you reply to all the comments, that way the reviewer can know whether you did that particular suggestion or not.

@starboi02
Copy link
Contributor Author

@starboi02 Please make sure that you reply to all the comments, that way the reviewer can know whether you did that particular suggestion or not.

@rt4914 sorry for that I will keep that in mind next time.

@starboi02
Copy link
Contributor Author

@starboi02 Suggested changes.

Also, please add details in your Explanation / Description

Something like
Fixes #2815: Add label to AdminPinActivity

@rt4914 thanks. I have made this change.

rt4914
rt4914 suggested changes Mar 18, 2021
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@starboi02 The tests are failing because in AdminPinActivityPresenter in line 38 the label is getting reset to Add Profiles. Suggest removing it and re-running the tests to see if that works.

@starboi02
Copy link
Contributor Author

@starboi02 The tests are failing because in AdminPinActivityPresenter in line 38 the label is getting reset to Add Profiles. Suggest removing it and re-running the tests to see if that works.

@rt4914 ok I will remove it.

@starboi02
Copy link
Contributor Author

@rt4914 I have made the change suggested.

prayutsu
prayutsu reviewed Mar 18, 2021
View reviewed changes
Copy link
Contributor

@prayutsu prayutsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost LGTM, Thanks @starboi02
Just had one comment to be confirmed by @rt4914.

@rt4914 rt4914 assigned rt4914 and unassigned starboi02 Mar 18, 2021
rt4914
rt4914 approved these changes Mar 19, 2021
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914 rt4914 assigned BenHenning and unassigned rt4914 Mar 19, 2021
BenHenning
BenHenning reviewed Mar 20, 2021
View reviewed changes
Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @starboi02! Just had 2 nits. PTAL.

app/src/main/java/org/oppia/android/app/profile/AdminPinActivityPresenter.kt Show resolved Hide resolved
app/src/sharedTest/java/org/oppia/android/app/profile/AdminPinActivityTest.kt Outdated Show resolved Hide resolved
app/src/sharedTest/java/org/oppia/android/app/profile/AdminPinActivityTest.kt Show resolved Hide resolved
@starboi02
Copy link
Contributor Author

@BenHenning I have made the suggested changes, please review.

anandwana001
anandwana001 suggested changes Mar 22, 2021
View reviewed changes
Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit change

.idea/misc.xml Outdated Show resolved Hide resolved
@anandwana001 anandwana001 removed their assignment Mar 22, 2021
@rt4914 rt4914 assigned anandwana001 and unassigned starboi02 Mar 22, 2021
BenHenning
BenHenning approved these changes Mar 22, 2021
View reviewed changes
Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @starboi02! LGTM.

@BenHenning BenHenning removed their assignment Mar 22, 2021
anandwana001
anandwana001 approved these changes Mar 23, 2021
View reviewed changes
Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anandwana001 anandwana001 merged commit 91e9467 into oppia:develop Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prayutsu prayutsu prayutsu approved these changes

@anandwana001 anandwana001 anandwana001 approved these changes

@BenHenning BenHenning BenHenning approved these changes

@rt4914 rt4914 rt4914 approved these changes

Assignees

@anandwana001 anandwana001

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[A11y] Add label for AdminPinActivity
5 participants
@starboi02 @anandwana001 @prayutsu @rt4914 @BenHenning