[A11y] Add label for AdminPinActivity #2815
Assignees
Labels
good first issue
This item is good for new contributors to make their pull request.
Priority: Essential
This work item must be completed for its milestone.
Type: Task
A single task of work corresponding to a greater milestone. Generally corresponds to a single PR.
Z-ibt
Temporary label for Ben to keep track of issues he's triaged.
Comments
rt4914
added
Priority: Essential
29 tasks
|
@rt4914 can I work on this one? |
|
@starboi02 Thanks for showing interest. Please checkout our wiki first. This will help you in setting up the project and once you sign the CLA and fill the survey form we can assign you issues to work on. |
|
@rt4914 thanks, I have signed the CLA and filled the survey from too. |
8 tasks
anandwana001
pushed a commit
that referenced
this issue
Mar 23, 2021
* Add label to AdminPinActivity * reverted ./idea/misc.xml * added newline to the end of ./idea/misc.xml * make changes requested * removed ./idea/misc.xml changes * changed string resource name in manifest file * redone lint check * removed resetting of activity label in AdminPinActivityPresenter * removed changes in ./idea/misc.xml * add comments * removed changes in misc.xml
BenHenning
added
the
Z-ibt
github-project-automation
bot
moved this to Todo
in [Team] Core Learner and Mastery flows & UI Frontend - Android
seanlip
moved this from Todo
to Done
in [Team] Core Learner and Mastery flows & UI Frontend - Android
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Task
Introduce label for
AdminPinActivityasAuthorise to add profiles.Reference PR: #2750
When you create a PR for this, make sure you add test to check the functionality. Also, suggest working on this PR only if its your first or second PR to Oppia-Android project.
General Explanation
When
Talkbackis on, whenever we click on any option which leads to new screen the reader will automatically read thelabelassociated with that screen first. If in case label in not present then it will read app name i.e.Oppia.Example
device-2021-02-24-021647.mp4
In this above video as soon as we double-tap
Battery, new screen is opened.The reader first outputs
Batteryfollowed byNavigate up, Buttonand finallyBatteryagain. In this the firstBatteryoutput is thelabelof this new screen which indicates the learner which screen is opened. The secondBatteryis because we selected the title in the screen and it's just reading that text.So we need
labelsfor various screens general which matches the title but if the title is dynamic then we need static label.The text was updated successfully, but these errors were encountered: