Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #1612: Few tests in StateFragmentTest don't need RunOn #2188

Merged
merged 1 commit into from
Dec 1, 2020
Merged

Fix part of #1612: Few tests in StateFragmentTest don't need RunOn #2188

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions app/src/sharedTest/java/org/oppia/android/app/player/state/StateFragmentTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,7 +472,6 @@ class StateFragmentTest {
}

@Test
@RunOn(TestPlatform.ESPRESSO) // TODO(#1612): Enable for Robolectric.
fun testStateFragment_loadDragDropExp_mergeFirstTwoItems_worksCorrectly() {
launchForExploration(TEST_EXPLORATION_ID_4).use {
startPlayingExploration()
Expand All @@ -491,7 +490,6 @@ class StateFragmentTest {
}

@Test
@RunOn(TestPlatform.ESPRESSO) // TODO(#1612): Enable for Robolectric.
fun testStateFragment_loadDragDropExp_mergeFirstTwoItems_invalidAnswer_correctItemCount() {
launchForExploration(TEST_EXPLORATION_ID_4).use {
startPlayingExploration()
Expand Down Expand Up @@ -535,7 +533,6 @@ class StateFragmentTest {
}

@Test
@RunOn(TestPlatform.ESPRESSO) // TODO(#1612): Enable for Robolectric.
fun testStateFragment_loadDragDropExp_mergeFirstTwoItems_unlinkFirstItem_worksCorrectly() {
launchForExploration(TEST_EXPLORATION_ID_4).use {
startPlayingExploration()
Expand All @@ -555,7 +552,6 @@ class StateFragmentTest {
}

@Test
@RunOn(TestPlatform.ESPRESSO) // TODO(#1611): Enable for Robolectric.
fun testStateFragment_loadImageRegion_clickRegion6_submitButtonClickable() {
launchForExploration(TEST_EXPLORATION_ID_5).use {
startPlayingExploration()
Expand All @@ -569,7 +565,6 @@ class StateFragmentTest {
}

@Test
@RunOn(TestPlatform.ESPRESSO) // TODO(#1611): Enable for Robolectric.
fun testStateFragment_loadImageRegion_clickRegion6_clickSubmit_receivesCorrectFeedback() {
launchForExploration(TEST_EXPLORATION_ID_5).use {
startPlayingExploration()
Expand All @@ -588,7 +583,6 @@ class StateFragmentTest {
}

@Test
@RunOn(TestPlatform.ESPRESSO) // TODO(#1611): Enable for Robolectric.
fun testStateFragment_loadImageRegion_submitButtonDisabled() {
launchForExploration(TEST_EXPLORATION_ID_5).use {
startPlayingExploration()
Expand All @@ -615,7 +609,6 @@ class StateFragmentTest {
}

@Test
@RunOn(TestPlatform.ESPRESSO) // TODO(#1611): Enable for Robolectric.
fun testStateFragment_loadImageRegion_clickedRegion6_region6Clicked_submitButtonEnabled() {
launchForExploration(TEST_EXPLORATION_ID_5).use {
startPlayingExploration()
Expand All @@ -629,7 +622,6 @@ class StateFragmentTest {
}

@Test
@RunOn(TestPlatform.ESPRESSO) // TODO(#1611): Enable for Robolectric.
fun testStateFragment_loadImageRegion_clickedRegion6_region6Clicked_correctFeedback() {
launchForExploration(TEST_EXPLORATION_ID_5).use {
startPlayingExploration()
Expand All @@ -648,7 +640,6 @@ class StateFragmentTest {
}

@Test
@RunOn(TestPlatform.ESPRESSO) // TODO(#1611): Enable for Robolectric.
fun testStateFragment_loadImageRegion_clickedRegion6_region6Clicked_correctAnswer() {
launchForExploration(TEST_EXPLORATION_ID_5).use {
startPlayingExploration()
Expand All @@ -667,7 +658,6 @@ class StateFragmentTest {
}

@Test
@RunOn(TestPlatform.ESPRESSO) // TODO(#1611): Enable for Robolectric.
fun testStateFragment_loadImageRegion_clickedRegion6_region6Clicked_continueButtonIsDisplayed() {
launchForExploration(TEST_EXPLORATION_ID_5).use {
startPlayingExploration()
Expand All @@ -682,7 +672,6 @@ class StateFragmentTest {
}

@Test
@RunOn(TestPlatform.ESPRESSO) // TODO(#1611): Enable for Robolectric.
fun loadImageRegion_clickRegion6_clickedRegion5_region5Clicked_correctFeedback() {
launchForExploration(TEST_EXPLORATION_ID_5).use {
startPlayingExploration()
Expand Down Expand Up @@ -821,7 +810,6 @@ class StateFragmentTest {
}

@Test
@RunOn(TestPlatform.ESPRESSO) // TODO(#1612): Enable for Robolectric.
@Ignore("Currently failing due to a regression") // TODO(#1769): Re-enable.
fun testStateFragment_loadExp_changeConfiguration_continueToEnd_hasReturnToTopicButton() {
launchForExploration(TEST_EXPLORATION_ID_2).use {
Expand Down Expand Up @@ -853,7 +841,6 @@ class StateFragmentTest {
}

@Test
@RunOn(TestPlatform.ESPRESSO) // TODO(#1612): Enable for Robolectric.
@Ignore("Currently failing due to a regression") // TODO(#1769): Re-enable.
fun testStateFragment_loadExp_changeConfig_continueToEnd_clickReturnToTopic_destroysActivity() {
launchForExploration(TEST_EXPLORATION_ID_2).use {
Expand Down