Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #1612: Few tests in StateFragmentTest don't need RunOn #2188

Merged
merged 1 commit into from
Dec 1, 2020

Conversation

anandwana001
Copy link
Contributor

@anandwana001 anandwana001 commented Nov 27, 2020

Explanation

Fix part of #1612
Remove unnecessary RunOn annotation

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@rt4914
Copy link
Contributor

rt4914 commented Nov 29, 2020

@anandwana001 Assigning @BenHenning to this PR considering that though it works correctly but in that case why was it introduced in the first place.

@rt4914 rt4914 assigned BenHenning and unassigned rt4914 Nov 29, 2020
Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. :) Curious that only a few of the drag & drop interactions actually need to be disabled.

@BenHenning
Copy link
Member

Thanks @anandwana001!

@rt4914 I think I just blanket disabled all of the drag & drop tests since I didn't expect any of them to work (and to some extent, I'm not actually sure why these ones pass without the shadow). Nevertheless, I think it's fine to reenable these given that we still have tests that fail without the Robolectric fixes (which are definitely necessary--I would be concerned if all of the tests passed since Robolectric is definitely producing the wrong behavior in these cases).

@BenHenning BenHenning merged commit b50b7ef into oppia:develop Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants