Reporting -> Insight not working properly

[myksto71]

Version 18.1.7, just updated.
I noticed a strange behaviour on the reporting section named "Insight".
I go on "Totals" tab then I go down to "Top usage ports/sources.
By default WAN is selected.
On the right of the graph I see several ip addresses (public ones) and if I go on the pie chart and select one of them, system takes me to the "Details" tab and put the ip address I select inside the "(src) Address" field as expected.
If I go back to the "Totals" tab, select "LAN" as the interface, choose and click on a IP adrress (private one this time) on the pie chart, system takes me to the "Details" tab but on the "src Address" put another IP address (public one) and NOT the one I chose before.

Beside if "WAN" is selected a small pop-up showing the ip address comes up when I go over the pie chart with the mouse but if I select LAN or another interface more often than not no IP is being shown.

I tried with Google Chrome and Mozilla Firefox and the behaviour is the same.

Is there a way to fix this "issue"?

Thanks a lot and cheers.

Michele.

[marjohn56]

Seems to be caused by d3.selectAll('.nvtooltip').remove(); at line 116 in networkinsight.volt, also at line 570.

@fichtner Who's the wizard on this?

I don't want to remove these and issue a PR if they are there for a reason.

[fichtner]

@AdSchellevis can you take a look at this when you have a moment?

[AdSchellevis]

I'll have a look as soon as I can find a bit of time..

[marjohn56]

There was a bug reported in nv3d with tooltips on pie charts, is that why it's there? I cannot make my mind up whether the bug is fixed or not after looking on Github.

I've commented out both instances of the *remove from the volt file and all seems to work OK.

[AdSchellevis]

@marjohn56 it was/is indeed for tooltips sticking on the screen after a refresh, as far as I know that's still the case without this, but this fix 7d98ae1 has other issues it seems. I'll get back on this.

[marjohn56]

Yes... I ended up here, which appears to be a fork.

krispo/angular-nvd3#616

[AdSchellevis]

there seems to be a newer version then we're using, but the patch in the angular repo doesn't appear to have a relation with the original code. let me upgrade nvd3 and revert 7d98ae1 maybe we're lucky...

[AdSchellevis]

ok, reverted 3ac6a82 and upgraded nv3d in fc05070 the tooltips seem to react better now, although I'm not sure this is perfect. (I'm not planning to dig into the internals of nvd3)

[marjohn56]

I'll try and give it a hammering over the coming weekend and see if I can break it.

[myksto71]

Hi.
I applied patches 3ac6a8 and fc0507.
Tooltips now show correctly but if I go on "Totals" tab and go down to "Top usage ports/sources", select "LAN" or "DMZ" as the interface, choose and click on a IP address (private one) on pie chart (the one on the right), system takes me to the "Details" tab, put "LAN" in the interface filed but on the "src Address" put another IP address (a public one) and NOT the one I chose before. This is the same behaviour as before the patches.

Thanks.

[AdSchellevis]

ok, found the culprit, but can't find a very nice fix, 08df2d0 does the trick on my end, but the issue actually seems to be that the event won't reattach in

core/src/opnsense/mvc/app/views/OPNsense/Diagnostics/networkinsight.volt

Line 365 in 08df2d0

chart.pie.dispatch.on('elementClick', function(e){

[myksto71]

Hello, any news on this front?

Thanks.

[fichtner]

New fix in 18.1.9 along with newer nvd3 library tomorrow.

[myksto71]

Oh wow, very good to know!
Thanks a lot and cheers!

[fichtner]

Be sure to check when out and close / report back if needed. Thanks!

[myksto71]

Sorry but I don't undestand what I should check.

[fichtner]

Once you have 18.1.9 installed, please recheck the page to confirm the reported errors are no longer there.

[myksto71]

Ah ok sorry.
Yes of course I'll report it back.

[myksto71]

Updated opnsense late this morning.
Made several tests. Insight behaviour seems to be regular and correct now.
Thanks to all the team for the good job made.
Cheers,
Michele.

[fichtner]

@myksto71 thanks, closing then :)