Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip still getting stuck #615 #616

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alanblins
Copy link

Despite #172 had been solved in case of changing data, this bug is still happening when it changes the options. Set the option useInteractiveGuideline=true. After populating data, change the current options such as tickFormat. This only happens with useInteractiveGuideline=true.
The cause of the problem is because clearElement is removing the wrong id tooltip.

Alan Lins added 2 commits January 31, 2017 11:25
Despite krispo#172 had been solved in case of changing data, bu it is stil happening when change options. Set the option useInteractiveGuideline true. After populate data, change  the current options like tickFormat. This only happens with useInteractiveGuideline=true.
@vladimanaev
Copy link

Is there an ETA for this to be merged? This is an annoying bug.

@anx-ckreuzberger
Copy link

This pull request works for me and fixes my bug! Can we get this in?

@dclangan
Copy link

This fixes my issue as well. Is there an ETA or is something else required to get this fix merged? Happy to help, if there is something I can do.

@bryangrimes
Copy link

This is causing us issues and soon we'll have to fork which is a shame. Is there something holding up this merge?

@pertrai1
Copy link

pertrai1 commented Sep 27, 2017

Has this merge been published to npm?

@Larvalis
Copy link

Larvalis commented Oct 2, 2017

Has this merge been published to npm?

Not yet.
It has been forked and merged into Awesense/angular-nvd3, but it has not gotten it's own publish on npm yet. So we are still waiting on this pull request :(

@AtofStryker
Copy link

any ETA on a merge?

@zamanianb
Copy link

When this get merged into production?

@pertrai1
Copy link

pertrai1 commented Nov 7, 2017

@Larvalis are we still at a standstill with this getting published?

@Larvalis
Copy link

Larvalis commented Nov 7, 2017

Yes, from what I can see there is no new updates.
Wondering myself if it is better to find an alternative project, or make a local version to use, as not getting updates on bugs and other things will be bad in the long run.
For now I am still waiting eagerly, as it is a minor issue yet.

@anx-ckreuzberger
Copy link

Maybe it helps if we page the maintainer of the repo! @krispo any chance you can take a look at this PR and merge it?

@pertrai1
Copy link

pertrai1 commented Nov 8, 2017

If we don’t see any action taken on this in next couple of weeks then I will fork and publish on npm under new version

@pertrai1
Copy link

I have gone ahead and created a new package on npm with this fix added to it. https://www.npmjs.com/package/angular-nvd3-charts. It is only this change and any PR's besides this are not included. Feel free to contribute to new repo if you still want to see this development move forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants