Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch empty state when public flag is toggled #16036

Merged
merged 10 commits into from
Jul 9, 2024
Merged

Switch empty state when public flag is toggled #16036

merged 10 commits into from
Jul 9, 2024

Commits on Jul 9, 2024

  1. Use correct icon in empty state for pviate lists

    @klaustopher
    klaustopher committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    866df14 View commit details
    Browse the repository at this point in the history

  2. Move loading of shares into the strategy

    @klaustopher
    klaustopher committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    15e3f69 View commit details
    Browse the repository at this point in the history

  3. Implement reloading the modal content on toggle public

    @klaustopher
    klaustopher committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    95d69f2 View commit details
    Browse the repository at this point in the history

  4. Use a better wrapper key for the modal body

    @klaustopher
    klaustopher committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    a1c2a33 View commit details
    Browse the repository at this point in the history

  5. Only generate turbo response when turbo is requested

    @klaustopher
    klaustopher committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    56f3c5a View commit details
    Browse the repository at this point in the history

  6. Rubocop

    @klaustopher
    klaustopher committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    57f870d View commit details
    Browse the repository at this point in the history

  7. Use params["value"] to set the publicstate

    @klaustopher
    klaustopher committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    5fc970d View commit details
    Browse the repository at this point in the history

  8. Fix specs

    @klaustopher
    klaustopher committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    4e40a49 View commit details
    Browse the repository at this point in the history

  9. Remove useless turbo tag

    @klaustopher
    klaustopher committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    92413ab View commit details
    Browse the repository at this point in the history

  10. Add tests for toggling to public and private

    @klaustopher
    klaustopher committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    c2775b2 View commit details
    Browse the repository at this point in the history