Switch empty state when public flag is toggled

[klaustopher]

One more left over ticket from #15971: When toggling the public state of the project list, re-render the modal

[klaustopher]

I am very very confused why this does not work. It renders the exact same response body as other replace calls, but it is not replacing

Response that works:

<turbo-stream action="replace" target="share_modal_body">
    <template>
      <turbo-frame id="share_modal_body">...</turbo-frame>
    </template>
</turbo-stream>

Response that does not work:

<turbo-stream action="replace" target="share_modal_body">
    <template>
      <turbo-frame id="share_modal_body">...</turbo-frame>
    </template>
</turbo-stream>

If anybody has an idea, I'd be very happy to understand why

[klaustopher]

It might boil down to how primer components mke the request. They generate a fetch request from their JS code.

https://github.com/primer/view_components/blob/ae8dbe23040ded74fab853ac3dc2068711c625f1/app/components/primer/alpha/toggle_switch.ts#L161-L172

@oliverguenther pointed out that the Accept header needs to contain text/vnd.turbo-stream.html but it doesn't since it just sets Accept: */*

[klaustopher]

We have to wait for a decision on primer/view_components#2940 if we can use the component or if we need to rebuild a bit from scratch so we can use turbo with it. We can already merge this and create anotehr follow up in the future

[toy]

Maybe check for params is not needed as calls to order are appended

[klaustopher]

The default order for a member is created_at, so it makes sense to reorder here depending on params being present