generate: fix "invalid CSV name" bug #4276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
kind/bug
`operator-sdk generate kustomize manifests` will auto-migrate a base CSV's name to `<package name>.v<version>` if it ends in `.vX.Y.Z`. `operator-sdk generate <bundle|packagemanifests` will always persist base CSV metadata unless `--version` or `--from-version` are set. internal/generate/clusterserviceversion: use an empty base if no CSVs are in the collector internal/generate/clusterserviceversion/bases: auto-migrate base name docs/olm-integration: document updated behavior
estroz
force-pushed
the
feature/read-csv-from-kustomize-build
branch
from
f8397a1 to
4e9ef97
Compare
varshaprasad96
approved these changes
Dec 4, 2020
estroz
pushed a commit
to estroz/operator-sdk
that referenced
this pull request
Dec 7, 2020
This commit fixes a bug caused by an invalid CSV name being generated. `operator-sdk generate kustomize manifests` will auto-migrate a base CSV's name to `<package name>.v<version>` if it ends in `.vX.Y.Z`. `operator-sdk generate <bundle|packagemanifests` will always persist base CSV metadata unless `--version` or `--from-version` are set. internal/generate/clusterserviceversion: use an empty base if no CSVs are in the collector internal/generate/clusterserviceversion/bases: auto-migrate base name docs/olm-integration: document updated behavior Co-authored-by: anmol372 <[email protected]>
reinvantveer
pushed a commit
to reinvantveer/operator-sdk
that referenced
this pull request
Feb 5, 2021
This commit fixes a bug caused by an invalid CSV name being generated. `operator-sdk generate kustomize manifests` will auto-migrate a base CSV's name to `<package name>.v<version>` if it ends in `.vX.Y.Z`. `operator-sdk generate <bundle|packagemanifests` will always persist base CSV metadata unless `--version` or `--from-version` are set. internal/generate/clusterserviceversion: use an empty base if no CSVs are in the collector internal/generate/clusterserviceversion/bases: auto-migrate base name docs/olm-integration: document updated behavior Co-authored-by: anmol372 <[email protected]> Signed-off-by: reinvantveer <[email protected]>
rearl-scwx
pushed a commit
to rearl-scwx/operator-sdk
that referenced
this pull request
Feb 5, 2021
This commit fixes a bug caused by an invalid CSV name being generated. `operator-sdk generate kustomize manifests` will auto-migrate a base CSV's name to `<package name>.v<version>` if it ends in `.vX.Y.Z`. `operator-sdk generate <bundle|packagemanifests` will always persist base CSV metadata unless `--version` or `--from-version` are set. internal/generate/clusterserviceversion: use an empty base if no CSVs are in the collector internal/generate/clusterserviceversion/bases: auto-migrate base name docs/olm-integration: document updated behavior Co-authored-by: anmol372 <[email protected]> Signed-off-by: rearl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Motivation for the change: This commit fixes a bug caused by an invalid CSV name being generated.
operator-sdk generate kustomize manifestswill auto-migrate a base CSV's name to<package name>.v<version>if it ends in.vX.Y.Z.operator-sdk generate <bundle|packagemanifestswill always persist base CSV metadata unless--versionor--from-versionare set./kind bug
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs