Added project name to the PROJECT config file #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
operator-sdk version
operator-sdk version: "v1.3.0-27-gdf8186c4-dirty", commit: "df8186c446c7e8d260bcd42216e59b4a08ce7185", kubernetes version: "v1.19.4", go version: "go1.15.5", GOOS: "linux", GOARCH: "amd64"I believe that error that was mentioned in the original issue was fixed in PR#4276. When I run make bundle
/home/mneverov/go/bin/controller-gen "crd:trivialVersions=true,preserveUnknownFields=false" rbac:roleName=manager-role webhook paths="./..." output:crd:artifacts:config=config/crd/bases
/home/mneverov/go/bin/operator-sdk generate kustomize manifests -q
/home/mneverov/go/bin/kustomize build config/manifests | /home/mneverov/go/bin/operator-sdk generate bundle -q --overwrite --manifests --version "0.18.0"
ERRO[0000] ClusterServiceVersion validation: [CSVFileNotValid] (.v0.18.0) metadata.name ".v0.18.0" is invalid:
[a lowercase RFC 1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')]
ERRO[0000] ClusterServiceVersion validation: [FieldNotFound] required field missing
FATA[0000] Error generating bundle manifests: error generating ClusterServiceVersion: invalid generated ClusterServiceVersion
Makefile:201: recipe for target 'bundle' failed
make: *** [bundle] Error 1ClusterServiceVersion validation: [CSVFileNotValid] (.v0.18.0) metadata.name ".v0.18.0" is invalid. Command Command make bundle
/home/mneverov/go/bin/controller-gen "crd:trivialVersions=true,preserveUnknownFields=false" rbac:roleName=manager-role webhook paths="./..." output:crd:artifacts:config=config/crd/bases
/home/mneverov/go/bin/operator-sdk generate kustomize manifests -q
/home/mneverov/go/bin/kustomize build config/manifests | /home/mneverov/go/bin/operator-sdk generate bundle -q --overwrite --manifests --version "0.18.0"
/home/mneverov/go/bin/operator-sdk bundle validate ./bundle
INFO[0000] Found annotations file bundle-dir=bundle container-tool=docker
INFO[0000] Could not find optional dependencies file bundle-dir=bundle container-tool=docker
INFO[0000] All validation tests have completed successfullyI committed all the changes that were done after successful command run. Let me know if I should revert |
Yes, they are generated post-release. |
jpkrohling
reviewed
Jan 25, 2021
config/manifests/bases/opentelemetry-operator.clusterserviceversion.yaml
Show resolved
Hide resolved
bundle/manifests/opentelemetry-operator.clusterserviceversion.yaml
Outdated
Show resolved
Hide resolved
mneverov
force-pushed
the
project_name_fix
branch
from
f1c69ab to
a428dcc
Compare
projectName field is needed for operator-sdk to deduct the metadata name for the project. When the bundle command reads input files from the stdin and no --project argument is provided, and projectName is absent the generated metadata name has invalid pattern: '.v0.18.0'. This commit adds the projectName field so metadata.name is correctly generated. Fixes open-telemetry#37
mneverov
force-pushed
the
project_name_fix
branch
from
a428dcc to
a11c42b
Compare
shree007
pushed a commit
to shree007/opentelemetry-operator
that referenced
this pull request
Dec 12, 2021
Added project name to the PROJECT config file projectName field is needed for operator-sdk to deduct the metadata name for the project. When the bundle command reads input files from the stdin and no --project argument is provided, and projectName is absent the generated metadata name has invalid pattern: '.v0.18.0'. This commit adds the projectName field so metadata.name is correctly generated. Fixes open-telemetry#37
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
Added project name to the PROJECT config file projectName field is needed for operator-sdk to deduct the metadata name for the project. When the bundle command reads input files from the stdin and no --project argument is provided, and projectName is absent the generated metadata name has invalid pattern: '.v0.18.0'. This commit adds the projectName field so metadata.name is correctly generated. Fixes open-telemetry#37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added project name to the PROJECT config file
projectName field is needed for operator-sdk to deduct the metadata name for the
project. When the bundle command reads input files from the stdin and no --project
argument is provided, and projectName is absent the generated metadata name has
invalid pattern: '.v0.18.0'.
This commit adds the projectName field so metadata.name is correctly generated.
Fixes #37