Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/operator-sdk: remove build subcommand #3566

Merged
merged 1 commit into from
Jul 27, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions changelog/fragments/remove-build.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
entries:
- description: Removed the `build` subcommand.
kind: removal
breaking: true
migration:
header: Remove `operator-sdk build` references from project
body: >
`operator-sdk build` was removed in favor of `make docker-build`. Any image build args passed
to the removed command can be directly added to the `docker-build` Makefile rule.
Any Go build args passed to the removed command can be directly added to the project's Dockerfile.
The image builder can be substituted for `docker` in the `docker-build` Makefile rule, assuming
flags are the same.
130 changes: 0 additions & 130 deletions cmd/operator-sdk/build/cmd.go

This file was deleted.

2 changes: 0 additions & 2 deletions cmd/operator-sdk/cli/cli.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
package cli

import (
"github.com/operator-framework/operator-sdk/cmd/operator-sdk/build"
"github.com/operator-framework/operator-sdk/cmd/operator-sdk/bundle"
"github.com/operator-framework/operator-sdk/cmd/operator-sdk/cleanup"
"github.com/operator-framework/operator-sdk/cmd/operator-sdk/completion"
Expand All @@ -37,7 +36,6 @@ import (
)

var commands = []*cobra.Command{
build.NewCmd(),
bundle.NewCmd(),
cleanup.NewCmd(),
completion.NewCmd(),
Expand Down
1 change: 0 additions & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ require (
github.com/fatih/structtag v1.1.0
github.com/go-logr/logr v0.1.0
github.com/go-logr/zapr v0.1.1
github.com/google/shlex v0.0.0-20191202100458-e7afc7fbc510
github.com/iancoleman/strcase v0.0.0-20191112232945-16388991a334
github.com/kr/text v0.1.0
github.com/markbates/inflect v1.0.4
Expand Down
2 changes: 0 additions & 2 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -372,8 +372,6 @@ github.com/google/gofuzz v1.1.0/go.mod h1:dBl0BpW6vV/+mYPU4Po3pmUjxk6FQPldtuIdl/
github.com/google/martian v2.1.0+incompatible/go.mod h1:9I4somxYTbIHy5NJKHRl3wXiIaQGbYVAs8BPL6v8lEs=
github.com/google/pprof v0.0.0-20181206194817-3ea8567a2e57/go.mod h1:zfwlbNMJ+OItoe0UupaVj+oy1omPYYDuagoSzA8v9mc=
github.com/google/renameio v0.1.0/go.mod h1:KWCgfxg9yswjAJkECMjeO8J8rahYeXnNhOm40UhjYkI=
github.com/google/shlex v0.0.0-20191202100458-e7afc7fbc510 h1:El6M4kTTCOh6aBiKaUGG7oYTSPP8MxqL4YI3kZKwcP4=
github.com/google/shlex v0.0.0-20191202100458-e7afc7fbc510/go.mod h1:pupxD2MaaD3pAXIBCelhxNneeOaAeabZDe5s4K6zSpQ=
github.com/google/uuid v1.0.0/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+yHo=
github.com/google/uuid v1.1.1 h1:Gkbcsh/GbpXz7lPftLA3P6TYMwjCLYm83jiFQZF/3gY=
github.com/google/uuid v1.1.1/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+yHo=
Expand Down
4 changes: 2 additions & 2 deletions hack/tests/e2e-ansible-molecule.sh
Original file line number Diff line number Diff line change
Expand Up @@ -58,12 +58,12 @@ KUSTOMIZE_PATH=${KUSTOMIZE} TEST_OPERATOR_NAMESPACE=default molecule test -s kin

popd
popd
KUSTOMIZE_PATH=${KUSTOMIZE}
KUSTOMIZE_PATH=${KUSTOMIZE}
header_text "Test Ansible Molecule scenarios"
pushd "${ROOTDIR}/test/ansible"
DEST_IMAGE="quay.io/example/ansible-test-operator:v0.0.1"
sed -i".bak" -E -e 's/(FROM quay.io\/operator-framework\/ansible-operator)(:.*)?/\1:dev/g' build/Dockerfile; rm -f build/Dockerfile.bak
operator-sdk build "$DEST_IMAGE" --image-build-args="--no-cache"
docker build -f build/Dockerfile -t "$DEST_IMAGE" --no-cache .
load_image_if_kind "$DEST_IMAGE"
OPERATOR_PULL_POLICY=Never OPERATOR_IMAGE=${DEST_IMAGE} TEST_CLUSTER_PORT=24443 TEST_OPERATOR_NAMESPACE=osdk-test molecule test --all

Expand Down
1 change: 0 additions & 1 deletion website/content/en/docs/cli/operator-sdk.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@ operator-sdk [flags]

### SEE ALSO

* [operator-sdk build](../operator-sdk_build) - Compiles code and builds artifacts
* [operator-sdk bundle](../operator-sdk_bundle) - Manage operator bundle metadata
* [operator-sdk cleanup](../operator-sdk_cleanup) - Clean up an Operator deployed with the 'run' subcommand
* [operator-sdk completion](../operator-sdk_completion) - Generators for shell completions
Expand Down
46 changes: 0 additions & 46 deletions website/content/en/docs/cli/operator-sdk_build.md

This file was deleted.